[navigation]feat: add home icon in left bottom #7802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuZhou-Joe
force-pushed
the
feature/add-home-icon
branch
from
d2f284c to
e1b726b
Compare
opensearch-changeset-bot bot
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Aug 22, 2024
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7802 +/- ##
=======================================
Coverage 63.83% 63.83%
=======================================
Files 3658 3659 +1
Lines 81284 81282 -2
Branches 12972 12972
=======================================
+ Hits 51884 51887 +3
+ Misses 26216 26215 -1
+ Partials 3184 3180 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AMoo-Miki
reviewed
Aug 22, 2024
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
AMoo-Miki
reviewed
Aug 22, 2024
| @@ -435,6 +435,7 @@ export function CollapsibleNavGroupEnabled({ | |||
| <div | |||
| className={classNames({ | |||
| 'bottom-container': true, | |||
| 'eui-xScroll': true, | |||
There was a problem hiding this comment.
How will this look on browser-OS combos that show a scrollbar?
There was a problem hiding this comment.
I get your point, I thought the class will help to hide the scrollbar, but if not, let me find if there is any pattern code I can follow in OSD.
There was a problem hiding this comment.
Seem behavior of adding the utility css class follows the OS settings. Was the intention to hide the scrollbar but allow user to scroll?
There was a problem hiding this comment.
I added -ms-overflow-style: -ms-autohiding-scrollbar; to the bottom container to make the behavior of scrollbar consistent. Do you think that's good enough?
There was a problem hiding this comment.
I'm fine with it, UX need to figure out how to fit those overflow icons, I think we can optimize this afterwards.
ruanyl
reviewed
Aug 23, 2024
| @@ -435,6 +435,7 @@ export function CollapsibleNavGroupEnabled({ | |||
| <div | |||
| className={classNames({ | |||
| 'bottom-container': true, | |||
| 'eui-xScroll': true, | |||
There was a problem hiding this comment.
Seem behavior of adding the utility css class follows the OS settings. Was the intention to hide the scrollbar but allow user to scroll?
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
force-pushed
the
feature/add-home-icon
branch
from
663ae7b to
c7b6c35
Compare
Hailong-am
reviewed
Aug 23, 2024
Signed-off-by: SuZhou-Joe <[email protected]>
ruanyl
previously approved these changes
Aug 23, 2024
Signed-off-by: SuZhou-Joe <[email protected]>
ruanyl
approved these changes
Aug 23, 2024
ananzh
approved these changes
Aug 23, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7802-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 106b64cd1e85df979fa8b78269b25f10057d284c
# Push it to GitHub
git push --set-upstream origin backport/backport-7802-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7802-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 106b64cd1e85df979fa8b78269b25f10057d284c
# Push it to GitHub
git push --set-upstream origin backport/backport-7802-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
SuZhou-Joe
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Aug 26, 2024
* feat: add home icon in left bottom Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless padding Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR opensearch-project#7802 created/updated * fix: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * feat: use flush Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize style Signed-off-by: SuZhou-Joe <[email protected]> * feat: move features around in nav group Signed-off-by: SuZhou-Joe <[email protected]> * fix: typo Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 106b64c)
7 tasks
ruanyl
pushed a commit
that referenced
this pull request
Aug 27, 2024
…7836) * [navigation]feat: add home icon in left bottom (#7802) * feat: add home icon in left bottom Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless padding Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #7802 created/updated * fix: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * feat: use flush Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize style Signed-off-by: SuZhou-Joe <[email protected]> * feat: move features around in nav group Signed-off-by: SuZhou-Joe <[email protected]> * fix: typo Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 106b64c) * fix: unit test error Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
|
Manually backported with #7802 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
manage workspacecategoryIssues Resolved
Screenshot
Home icon in left bottom
Make left bottom container scrollable
Add workspace settings under manage workspace category
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration